helpful

commit e1b660e2a48b39b0a81119c2593362dd60076757
parent 1b8a99a6c3857ecd09bf39702158939d3c3af63d
Author: Wilfred Hughes <me@wilfred.me.uk>
Date:   Thu, 11 Jan 2018 23:02:42 +0000

Don't prompt the user about unsafe buffer-local variables

When we are opening a buffer for source code, we're essentially in
batch mode.

Diffstat:
M
CHANGELOG.md
 | 
3
+++
M
helpful.el
 | 
9
+++++++--

2 files changed, 10 insertions(+), 2 deletions(-)
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -29,6 +29,9 @@ least recently accessed. Previously, we killed in creation order.
 If a function also has a unit test of the same name, allow it to be
 run directly from the property list.
 
+Fixed an issue where we would repeatedly prompt the user regarding
+unsafe buffer-local variables.
+
 # v0.5
 
 Allow function tracing to be enabled/disabled from Helpful buffers.
diff --git a/helpful.el b/helpful.el
@@ -788,7 +788,11 @@ buffer."
       ;;
       ;; Bind `auto-mode-alist' to nil, so we open the buffer in
       ;; `fundamental-mode' if it isn't already open.
-      (let (auto-mode-alist)
+      (let (auto-mode-alist
+            ;; Don't both setting buffer-local variables, it's
+            ;; annoying to prompt the user since we immediately
+            ;; discard the buffer.
+            enable-local-variables)
         (setq buf (find-file-noselect (find-library-name path))))
 
       (unless (-contains-p initial-buffers buf)
@@ -800,7 +804,8 @@ buffer."
       ;; table for searching.
       (when opened
         (with-current-buffer buf
-          (delay-mode-hooks (normal-mode))))
+          (let (enable-local-variables)
+            (delay-mode-hooks (normal-mode t)))))
 
       ;; Based on `find-function-noselect'.
       (with-current-buffer buf