org-download

commit 34e76413208a9390d194aeecf2f2981eaf55df1e
parent 29d919126fac7277261bce96c99744e35d3c193d
Author: conao3 <conao3@gmail.com>
Date:   Sun, 17 Nov 2019 18:31:46 +0900

fix package-lint warnings

This fixes below package-lint warnings

Including "Emacs" in the package summary is usually redundant.
You should depend on (emacs "24") if you need lexical-binding.
You should include standard keywords: see the variable `finder-known-keywords'.
You should depend on (emacs "24.1") if you need `org-display-inline-images'.
You should depend on (emacs "24.3") if you need `url-path-and-query'.
You should convert this comment to documentation
Messages should start with a capital letter
You should depend on (emacs "24.3") if you need `org-element-property'.
You should depend on (emacs "24.3") if you need `org-element-context'.
You should depend on (emacs "24.3") if you need `file-name-base'.
You should depend on (emacs "24.3") if you need `org-element-context'.
Messages should start with a capital letter
You should depend on (emacs "24.3") if you need `user-error'.

Diffstat:
M
org-download.el
 | 
12
++++++------

1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/org-download.el b/org-download.el
@@ -1,12 +1,12 @@
-;;; org-download.el --- Image drag-and-drop for Emacs org-mode. -*- lexical-binding: t -*-
+;;; org-download.el --- Image drag-and-drop for Org-mode. -*- lexical-binding: t -*-
 
 ;; Copyright (C) 2014-2019 Free Software Foundation, Inc.
 
 ;; Author: Oleh Krehel
 ;; URL: https://github.com/abo-abo/org-download
 ;; Version: 0.1.0
-;; Package-Requires: ((async "1.2"))
-;; Keywords: images, screenshots, download
+;; Package-Requires: ((emacs "24.3") (async "1.2"))
+;; Keywords: multimedia images screenshots download
 
 ;; This file is not part of GNU Emacs.
 
@@ -306,7 +306,7 @@ COMMAND is a format-style string with two slots for LINK and FILENAME."
          (org-download--display-inline-images))))))
 
 (defun org-download--write-image (status filename)
-  ;; Write current buffer to FILENAME
+  "Write current buffer STATUS to FILENAME."
   (let ((err (plist-get status :error)))
     (when err
       (error
@@ -400,7 +400,7 @@ It's inserted before the image link and is used to annotate it.")
                  (when (re-search-forward "^Content-Type: image/\\(.*\\)$")
                    (setq ext (match-string 1)))))
               (t
-               (error "link %s does not point to an image; unaliasing failed" link)))))
+               (error "Link %s does not point to an image; unaliasing failed" link)))))
     (let ((filename
            (cond ((eq org-download-method 'attach)
                   (let ((org-download-image-dir (progn (require 'org-attach)
@@ -540,7 +540,7 @@ It's inserted before the image link and is used to annotate it.")
   (interactive)
   (let ((context (org-element-context)))
     (if (not (eq (car-safe context) 'link))
-        (user-error "not on a link")
+        (user-error "Not on a link")
       (start-process-shell-command
        "org-download-edit"
        "org-download-edit"